Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1181603004: Add AnalysisContext.onResultComputed(). (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add AnalysisContext.onResultComputed(). Add RESOLVED_UNIT_NO_CONSTANTS as a public result. Document results that are computed with the task model. We need this to be able to use onResultComputed() in Analysis Server and know that we will get enough information. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cdced40bd56801471cbe9366330880cf2e9a54f5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rollback to RESOLVED_UNIT6. #

Patch Set 3 : Rename ResultComputedEvent -> ComputedResult. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -41 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 2 2 chunks +5 lines, -30 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 2 5 chunks +57 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 1 2 4 chunks +8 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 6 months ago (2015-06-11 16:33:24 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1181603004/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1181603004/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode10788 pkg/analyzer/lib/src/generated/engine.dart:10788: class ResultComputedEvent<V> { Perhaps "ComputedResult"?
5 years, 6 months ago (2015-06-11 16:44:45 UTC) #2
scheglov
https://codereview.chromium.org/1181603004/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1181603004/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode10788 pkg/analyzer/lib/src/generated/engine.dart:10788: class ResultComputedEvent<V> { On 2015/06/11 16:44:44, Brian Wilkerson wrote: ...
5 years, 6 months ago (2015-06-11 17:43:25 UTC) #3
scheglov
5 years, 6 months ago (2015-06-11 17:44:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
cdced40bd56801471cbe9366330880cf2e9a54f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698