Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1181583004: Fix test on Windows (Closed)

Created:
5 years, 6 months ago by Søren Gjesse
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test on Windows Forgot to change Platform.executable to Platform.resolvedExecutable in one place. TBR=lrn@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f9e8852edb1476b1b0c93b9beda99634eb248f4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/standalone/io/platform_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 6 months ago (2015-06-15 09:45:19 UTC) #1
Søren Gjesse
Committed patchset #1 (id:1) manually as f9e8852edb1476b1b0c93b9beda99634eb248f4b (presubmit successful).
5 years, 6 months ago (2015-06-15 09:47:32 UTC) #2
Lasse Reichstein Nielsen
5 years, 6 months ago (2015-06-15 16:03:17 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698