refactor Reqest.fromJson for use by performance measurement tests

refactor Reqest.fromJson for use by performance measurement tests

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/db11964b83a76d562a06fad10e5c3ec5bdee22f0

[danrubel, 2015-06-15 15:22:25]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-06-15 15:41:40]

LGTM

https://codereview.chromium.org/1181363004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/1181363004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol.dart:554: *     'clientRequestTime':
millisecondsSinceEpoch
nit: It would look nicer if this line were moved before 'id' and it would keep
the keys alphabetized.

https://codereview.chromium.org/1181363004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol.dart:562: factory Request.fromJson(result)
{
Parameters should have type annotations. Can we move the test for whether
'result' is a map into fromString?

[danrubel, 2015-06-15 16:25:18]

https://codereview.chromium.org/1181363004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/1181363004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol.dart:554: *     'clientRequestTime':
millisecondsSinceEpoch
On 2015/06/15 15:41:40, Brian Wilkerson wrote:
> nit: It would look nicer if this line were moved before 'id' and it would keep
> the keys alphabetized.

Done.

https://codereview.chromium.org/1181363004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol.dart:562: factory Request.fromJson(result)
{
On 2015/06/15 15:41:40, Brian Wilkerson wrote:
> Parameters should have type annotations. Can we move the test for whether
> 'result' is a map into fromString?

Done.

[danrubel, 2015-06-15 16:27:46]

Committed patchset #2 (id:20001) manually as
db11964b83a76d562a06fad10e5c3ec5bdee22f0 (presubmit successful).