Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 1181223002: Fix for computeResolvedCompilationUnitAsync(). (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for computeResolvedCompilationUnitAsync(). This fixes the last Analysis Server unit tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/61c01b2231ff2348d4f7808b829b29652bcc7a34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 8 chunks +32 lines, -21 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 4 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-12 16:50:13 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-12 17:22:30 UTC) #2
scheglov
5 years, 6 months ago (2015-06-12 17:27:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61c01b2231ff2348d4f7808b829b29652bcc7a34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698