Fix for issue 23432 - Get the correct receiver in noSuchMethod stubs.

Fix for issue 23432.

Get the correct receiver in noSuchMethod stubs.

noSuchMethod stubs for selectors with Interceptor calling convention should pass the receiver to noSuchMethod (not 'this').  The actual receiver is selected by Object.noSuchMethod and Interceptor.noSuchMethod.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/c8d7cd8ef46de11f5e4e7c757bb9ee2f12cb8cd6

Reverted: https://github.com/dart-lang/sdk/commit/21a322fd9969260a22034a372df8b62e9ca20456

Committed: https://github.com/dart-lang/sdk/commit/afe5b32e48b56afb9b1eebc705830491acb4640a

[sra1, 2015-06-19 00:25:23]

Patchset #1 (id:1) has been deleted

[sra1, 2015-06-19 04:07:59]

Patchset #1 (id:20001) has been deleted

[sra1, 2015-06-19 04:08:07]

Patchset #1 (id:40001) has been deleted

[sra1, 2015-06-19 04:11:08]

sra@google.com changed reviewers:
+ floitsch@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2015-06-19 18:33:22]

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:324:
Array.prototype.slice.call(arguments),
woudln't this return []? do we need splice here?

[sra1, 2015-06-19 18:59:38]

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:324:
Array.prototype.slice.call(arguments),
On 2015/06/19 18:33:22, Siggi Cherem (dart-lang) wrote:
> woudln't this return []? do we need splice here?
> 

slice copies a slice of the input.
'arguments' contains all passed arguments, regardless of the function's declared
parameters.
We must copy since 'arguments' is not a JS Array, it is just 'array-like' which
is not good enough for Dart code.

In ES6 we would probably use  function(...args) {...}

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

[Siggi Cherem (dart-lang), 2015-06-19 19:46:00]

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:324:
Array.prototype.slice.call(arguments),
On 2015/06/19 18:59:38, sra1 wrote:
> On 2015/06/19 18:33:22, Siggi Cherem (dart-lang) wrote:
> > woudln't this return []? do we need splice here?
> > 
> 
> slice copies a slice of the input.
> 'arguments' contains all passed arguments, regardless of the function's
declared
> parameters.
> We must copy since 'arguments' is not a JS Array, it is just 'array-like'
which
> is not good enough for Dart code.
> 
> In ES6 we would probably use  function(...args) {...}
> 
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

Then are we missing the 0 argument here? That is:

   Array.prototype.slice.call(arguments, 0)

instead of:
   Array.prototype.slice.call(arguments)

(the latter seems to return [])?

[floitsch, 2015-06-19 21:22:15]

LGTM.
Please change the title of the CL.

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:281: dynamic
isIntercepted = // jsAst.Expression or bool.
firstNormalSelector != 0 &&
(firstNormalSelector == shorts.length || js('j < #',
js.number(firstNormalSelector))

?

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:313:
Array.prototype.slice.call(arguments, 1),
add comment what the "1" is.

https://codereview.chromium.org/1181063005/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:322: this,  //
Could be dummy receiver.
how is that possible?
if the call is not intercepted then 'this' shouldn't be the dummy receiver. no?

Or are you saying that we could also pass a dummy-receiver? In that case change
the comment to: "// Value is ignored. We could also pass the dummy receiver.

[sra1, 2015-06-22 20:16:21]

Committed patchset #2 (id:80001) manually as
c8d7cd8ef46de11f5e4e7c757bb9ee2f12cb8cd6 (presubmit successful).

[sra1, 2015-06-22 20:17:00]

https://chromiumcodereview.appspot.com/1181063005/diff/60001/pkg/compiler/lib...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://chromiumcodereview.appspot.com/1181063005/diff/60001/pkg/compiler/lib...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:281: dynamic
isIntercepted = // jsAst.Expression or bool.
On 2015/06/19 21:22:15, floitsch wrote:
> firstNormalSelector != 0 &&
> (firstNormalSelector == shorts.length || js('j < #',
> js.number(firstNormalSelector))
> 
> ?

You can't use || to pick the jsAst.  || is bool*bool->bool

https://chromiumcodereview.appspot.com/1181063005/diff/60001/pkg/compiler/lib...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:313:
Array.prototype.slice.call(arguments, 1),
On 2015/06/19 21:22:15, floitsch wrote:
> add comment what the "1" is.

Done.

https://chromiumcodereview.appspot.com/1181063005/diff/60001/pkg/compiler/lib...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:322: this,  //
Could be dummy receiver.
On 2015/06/19 21:22:15, floitsch wrote:
> how is that possible?
> if the call is not intercepted then 'this' shouldn't be the dummy receiver.
no?
> 
> Or are you saying that we could also pass a dummy-receiver? In that case
change
> the comment to: "// Value is ignored. We could also pass the dummy receiver.

Done.

https://chromiumcodereview.appspot.com/1181063005/diff/60001/pkg/compiler/lib...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:324:
Array.prototype.slice.call(arguments),
On 2015/06/19 19:46:00, Siggi Cherem (dart-lang) wrote:
> On 2015/06/19 18:59:38, sra1 wrote:
> > On 2015/06/19 18:33:22, Siggi Cherem (dart-lang) wrote:
> > > woudln't this return []? do we need splice here?
> > > 
> > 
> > slice copies a slice of the input.
> > 'arguments' contains all passed arguments, regardless of the function's
> declared
> > parameters.
> > We must copy since 'arguments' is not a JS Array, it is just 'array-like'
> which
> > is not good enough for Dart code.
> > 
> > In ES6 we would probably use  function(...args) {...}
> > 
> >
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...
> 
> Then are we missing the 0 argument here? That is:
> 
>    Array.prototype.slice.call(arguments, 0)
> 
> instead of:
>    Array.prototype.slice.call(arguments)
> 
> (the latter seems to return [])?

"If begin is omitted, slice begins from index 0."

$ function f(){return Array.prototype.slice.call(arguments)}
undefined
$ f(1,2,3)
[1, 2, 3]

[Siggi Cherem (dart-lang), 2015-06-22 20:37:32]

https://chromiumcodereview.appspot.com/1181063005/diff/60001/pkg/compiler/lib...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://chromiumcodereview.appspot.com/1181063005/diff/60001/pkg/compiler/lib...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:324:
Array.prototype.slice.call(arguments),
On 2015/06/22 20:17:00, sra1 wrote:
> On 2015/06/19 19:46:00, Siggi Cherem (dart-lang) wrote:
> > On 2015/06/19 18:59:38, sra1 wrote:
> > > On 2015/06/19 18:33:22, Siggi Cherem (dart-lang) wrote:
> > > > woudln't this return []? do we need splice here?
> > > > 
> > > 
> > > slice copies a slice of the input.
> > > 'arguments' contains all passed arguments, regardless of the function's
> > declared
> > > parameters.
> > > We must copy since 'arguments' is not a JS Array, it is just 'array-like'
> > which
> > > is not good enough for Dart code.
> > > 
> > > In ES6 we would probably use  function(...args) {...}
> > > 
> > >
> >
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...
> > 
> > Then are we missing the 0 argument here? That is:
> > 
> >    Array.prototype.slice.call(arguments, 0)
> > 
> > instead of:
> >    Array.prototype.slice.call(arguments)
> > 
> > (the latter seems to return [])?
> 
> "If begin is omitted, slice begins from index 0."
> 
> $ function f(){return Array.prototype.slice.call(arguments)}
> undefined
> $ f(1,2,3)
> [1, 2, 3]

Sorry for all the silly questions here. Apparently I can't read. I originally
read splice instead of slice, and was playing with examples using `splice` and
hence the source of all my confusion.

It all makes sense now.

[sra1, 2015-06-23 00:02:32]

Committed patchset #4 (id:120001) manually as
afe5b32e48b56afb9b1eebc705830491acb4640a (presubmit successful).