Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1181043003: be more explicit about when and how to register for listeners with isolates (Closed)

Created:
5 years, 6 months ago by sethladd
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org, nweiz
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

be more explicit about when and how to register for listeners with isolates BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/00be3be57195868b06740012a2a3dedfe386e7ef

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M sdk/lib/isolate/isolate.dart View 2 chunks +8 lines, -0 lines 3 comments Download

Messages

Total messages: 8 (2 generated)
sethladd
Prompted from https://github.com/dart-lang/sdk/issues/23609#issuecomment-111236195 Also, I've seen others run into this problem.
5 years, 6 months ago (2015-06-12 09:44:15 UTC) #2
Lasse Reichstein Nielsen
lgtm
5 years, 6 months ago (2015-06-12 13:01:22 UTC) #3
sethladd
Committed patchset #1 (id:1) manually as 00be3be57195868b06740012a2a3dedfe386e7ef (presubmit successful).
5 years, 6 months ago (2015-06-12 13:02:17 UTC) #4
nweiz
https://codereview.chromium.org/1181043003/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://codereview.chromium.org/1181043003/diff/1/sdk/lib/isolate/isolate.dart#newcode372 sdk/lib/isolate/isolate.dart:372: * Since isolates run concurrently, it's possible for it ...
5 years, 6 months ago (2015-06-12 19:18:56 UTC) #6
Lasse Reichstein Nielsen
https://codereview.chromium.org/1181043003/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://codereview.chromium.org/1181043003/diff/1/sdk/lib/isolate/isolate.dart#newcode372 sdk/lib/isolate/isolate.dart:372: * Since isolates run concurrently, it's possible for it ...
5 years, 6 months ago (2015-06-12 19:38:16 UTC) #7
nweiz
5 years, 6 months ago (2015-06-12 21:05:43 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1181043003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1181043003/diff/1/sdk/lib/isolate/isolate.dar...
sdk/lib/isolate/isolate.dart:372: * Since isolates run concurrently, it's
possible for it to exit before the
On 2015/06/12 19:38:16, Lasse Reichstein Nielsen wrote:
> "exit or emit an error"?
> 
> It can do either or both.

That's true, but if it exits before the listener is established the listener
just won't fire—the same as if it exits afterwards. I think the unintuitive
behavior is particular to emitting errors.

Powered by Google App Engine
This is Rietveld 408576698