Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 1180883003: Don't create navigation regions for not existing sources. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't create navigation regions for not existing sources. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f3c28ef4493ad82f066a43dd3dd855b66cbfc6c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 5 chunks +19 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-11 19:51:18 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-11 20:02:18 UTC) #2
scheglov
5 years, 6 months ago (2015-06-11 20:21:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3c28ef4493ad82f066a43dd3dd855b66cbfc6c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698