recompute package map when input file changes

recompute package map when input file changes

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb950645115663d3fc00431df5a38e272c2df488

[danrubel, 2015-06-18 19:45:25]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-06-18 20:15:53]

lgtm

https://codereview.chromium.org/1180843011/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1180843011/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/context_manager.dart:439: for (String dependencyPath
in packageMapInfo.dependencies) {
There's a small race condition here, which is that if a dependency changes after
the call to computePackageMap but before we start watching it, we won't notice
the change.  I think it's ok to commit this code as is and defer that race
condition until later, but would you mind adding a TODO comment to capture it?

https://codereview.chromium.org/1180843011/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/context_manager.dart:458: // TODO(paulberry): if any
of the dependencies is outside of [folder],
Remove this TODO.

[danrubel, 2015-06-20 21:19:04]

Committed patchset #2 (id:20001) manually as
eb950645115663d3fc00431df5a38e272c2df488 (presubmit successful).

[Paul Berry, 2015-06-22 14:59:55]

On 2015/06/20 21:19:04, danrubel wrote:
> Committed patchset #2 (id:20001) manually as
> eb950645115663d3fc00431df5a38e272c2df488 (presubmit successful).

This breaks 17 analysis server integration tests on Linux, e.g.:

python tools/test.py --checked -mrelease -t60
pkg/analysis_server/test/integration/completion/get_suggestions_test

The integration tests pass on mac.

I'm not sure why this wasn't picked up by a buildbot.  I'll investigate that. 
Dan, would you mind looking into the failures themselves?

[danrubel, 2015-06-22 15:41:22]

On 2015/06/22 14:59:55, Paul Berry wrote:
> On 2015/06/20 21:19:04, danrubel wrote:
> > Committed patchset #2 (id:20001) manually as
> > eb950645115663d3fc00431df5a38e272c2df488 (presubmit successful).
> 
> This breaks 17 analysis server integration tests on Linux, e.g.:
> 
> python tools/test.py --checked -mrelease -t60
> pkg/analysis_server/test/integration/completion/get_suggestions_test
> 
> The integration tests pass on mac.
> 
> I'm not sure why this wasn't picked up by a buildbot.  I'll investigate that. 
> Dan, would you mind looking into the failures themselves?

Yes, I landed
https://github.com/dart-lang/sdk/commit/d907a4265e1c1350e00377c9995af6c84370b02c
earlier this morning in an attempt to gather more information about what
exception was occurring, but unfortunately the stacktrace returned is null. I'll
continue to dig.