Issue 1180843007: Ignore test files in third_party/pkg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1180843007: Ignore test files in third_party/pkg (Closed)

Created:
5 years, 6 months ago by ricow1

Modified:
5 years, 6 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Ignore test files in third_party/pkg we don't run these and they are making us go over the limit for xcodefiles R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9b74249d889589f4fdfc222172b2efb4c0c633ba

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/pkg_files.gyp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Bill Hesse

I think you are testing that the excluded files end in .dart twice in the ...

5 years, 6 months ago (2015-06-18 06:42:11 UTC) #2

ricow1

On 2015/06/18 06:42:11, Bill Hesse wrote: > I think you are testing that the excluded ...

5 years, 6 months ago (2015-06-18 06:44:54 UTC) #3

Bill Hesse

lgtm Oh yes. I keep thinking this is an exclusion list (!includes), and missed the ...

5 years, 6 months ago (2015-06-18 06:54:22 UTC) #4

ricow1

5 years, 6 months ago (2015-06-18 06:55:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9b74249d889589f4fdfc222172b2efb4c0c633ba (presubmit successful).