Issue 1180773005: add generation of docs by dartdoc on the bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1180773005: add generation of docs by dartdoc on the bots (Closed)

Created:
5 years, 6 months ago by keertip

Modified:
5 years, 6 months ago

Reviewers:
ricow1, pquitslund

CC:
reviews_dartlang.org, ricow1

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

add generation of docs by dartdoc on the bots BUG= R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/72ac998b8df0a439c4a2a3313e55b9f33bf7b246

Patch Set 1 #

Total comments: 2

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	DEPS	View		3 chunks	+12 lines, -0 lines	2 comments	Download
	M	tools/bots/dart_sdk.py	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

keertip

Trying to land this cl again now that the deps have been fixed on the ...

5 years, 6 months ago (2015-06-18 16:33:06 UTC) #2

pquitslund

lgtm https://codereview.chromium.org/1180773005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1180773005/diff/1/DEPS#newcode196 DEPS:196: "https://github.com/dart-lang/dartdoc.git" + Var("dartdoc_tag"), I'm guessing Rico is working ...

5 years, 6 months ago (2015-06-18 17:23:34 UTC) #3

keertip

Committed patchset #1 (id:1) manually as 72ac998b8df0a439c4a2a3313e55b9f33bf7b246 (presubmit successful).

5 years, 6 months ago (2015-06-18 17:30:38 UTC) #4

keertip

5 years, 6 months ago (2015-06-18 17:35:19 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1180773005/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1180773005/diff/1/DEPS#newcode196
DEPS:196: "https://github.com/dart-lang/dartdoc.git" + Var("dartdoc_tag"),
On 2015/06/18 17:23:34, pquitslund wrote:
> I'm guessing Rico is working on a mirror?

There is an issue for this.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages