Create LibraryElement with SDK context for SDK sources.

Create LibraryElement with SDK context for SDK sources.

This fixes 3 or 6 failing Analysis Server tests.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/c2cc0387a8aabc778572f00415b89b35f87f1e91

[Brian Wilkerson, 2015-06-11 18:49:51]

LGTM

https://codereview.chromium.org/1180673008/diff/1/pkg/analyzer/lib/task/model...
File pkg/analyzer/lib/task/model.dart (right):

https://codereview.chromium.org/1180673008/diff/1/pkg/analyzer/lib/task/model...
pkg/analyzer/lib/task/model.dart:94: final InternalAnalysisContext context;
Clients are expected to extend AnalysisTask, but InternalAnalysisContext isn't
part of the public API, so we can't use it here.

To be safe, I suppose the code in the task should be something like:

AnalysisContext owningContext = context;
if (context is InternalAnalysisContext) {
  owningContext = context.getContextFor(librarySource);
}
... new LibraryElementImpl.forNode(owningContext, ...);

[scheglov, 2015-06-11 18:56:08]

https://codereview.chromium.org/1180673008/diff/1/pkg/analyzer/lib/task/model...
File pkg/analyzer/lib/task/model.dart (right):

https://codereview.chromium.org/1180673008/diff/1/pkg/analyzer/lib/task/model...
pkg/analyzer/lib/task/model.dart:94: final InternalAnalysisContext context;
On 2015/06/11 18:49:51, Brian Wilkerson wrote:
> Clients are expected to extend AnalysisTask, but InternalAnalysisContext isn't
> part of the public API, so we can't use it here.
> 
> To be safe, I suppose the code in the task should be something like:
> 
> AnalysisContext owningContext = context;
> if (context is InternalAnalysisContext) {
>   owningContext = context.getContextFor(librarySource);
> }
> ... new LibraryElementImpl.forNode(owningContext, ...);

Done.

[scheglov, 2015-06-11 18:57:28]

Committed patchset #2 (id:20001) manually as
c2cc0387a8aabc778572f00415b89b35f87f1e91 (presubmit successful).