Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Issue 1180613008: Fix prints/throws tests on the latest dart2js. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix prints/throws tests on the latest dart2js. Rather than trying to keep up with the latest and greatest implementations of Function.toString, this just avoids verifying the function string values at all. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/61ec8c87441153d20f4c55f509544fb78a0d3548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -66 lines) Patch
M test/frontend/matcher/prints_test.dart View 2 chunks +70 lines, -48 lines 0 comments Download
M test/frontend/matcher/throws_test.dart View 4 chunks +32 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 6 months ago (2015-06-11 21:26:28 UTC) #1
kevmoo
lgtm
5 years, 6 months ago (2015-06-12 11:49:52 UTC) #2
nweiz
5 years, 6 months ago (2015-06-15 22:53:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61ec8c87441153d20f4c55f509544fb78a0d3548 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698