Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 11806003: Fix context chaining to prevent memory leak (issue 7681). (Closed)

Created:
7 years, 11 months ago by regis
Modified:
7 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix context chaining to prevent memory leak (issue 7681). Committed: https://code.google.com/p/dart/source/detail?r=16757

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +15 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 11 months ago (2013-01-07 21:41:06 UTC) #1
Ivan Posva
LGTM -ip https://codereview.chromium.org/11806003/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/11806003/diff/1/runtime/vm/parser.cc#newcode191 runtime/vm/parser.cc:191: // context but saved on entry and ...
7 years, 11 months ago (2013-01-07 22:19:11 UTC) #2
regis
7 years, 11 months ago (2013-01-07 22:24:01 UTC) #3
Thanks

https://codereview.chromium.org/11806003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/11806003/diff/1/runtime/vm/parser.cc#newcode191
runtime/vm/parser.cc:191: // context but saved on entry and restored on exit as
to prevent memory leaks.
On 2013/01/07 22:19:11, Ivan Posva wrote:
> Please update the bug, but do not close it as we still need to ensure the
> closures which do not need chained contexts do not remember the current
context
> on allocation.

Done.

Powered by Google App Engine
This is Rietveld 408576698