Issue 11798004: - Add a test for context cycles. Based on dartbug.com/7681.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11798004: - Add a test for context cycles. Based on dartbug.com/7681. (Closed)

Created:
7 years, 11 months ago by Ivan Posva

Modified:
7 years, 11 months ago

Reviewers:
regis, siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Add a test for context cycles. Based on dartbug.com/7681. Committed: https://code.google.com/p/dart/source/detail?r=16805

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	A	tests/language/closure_cycles_test.dart	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/11798004/diff/1/tests/language/closure_cycles_test.dart File tests/language/closure_cycles_test.dart (right): https://codereview.chromium.org/11798004/diff/1/tests/language/closure_cycles_test.dart#newcode7 tests/language/closure_cycles_test.dart:7: import "dart:async"; I think you need a library ...

7 years, 11 months ago (2013-01-07 22:10:18 UTC) #2

Ivan Posva

7 years, 11 months ago (2013-01-08 17:37:38 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11798004/diff/1/tests/language/closure_cycles...
File tests/language/closure_cycles_test.dart (right):

https://codereview.chromium.org/11798004/diff/1/tests/language/closure_cycles...
tests/language/closure_cycles_test.dart:7: import "dart:async";
On 2013/01/07 22:10:18, regis wrote:
> I think you need a library statement for Dartium test harness.

Done.

https://codereview.chromium.org/11798004/diff/1/tests/language/closure_cycles...
tests/language/closure_cycles_test.dart:21: // Termintate the test if we
allocated enough memory without running out.
On 2013/01/07 22:10:18, regis wrote:
> Terminate

Done.

Expand Messages | Collapse Messages

Issue 11798004: - Add a test for context cycles. Based on dartbug.com/7681. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages