Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1179743003: Supported plugin access. (Closed)

Created:
5 years, 6 months ago by pquitslund
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +31 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 6 months ago (2015-06-11 18:25:12 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1179743003/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1179743003/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode5821 pkg/analyzer/lib/src/generated/engine.dart:5821: * Get the list of supported plugins for ...
5 years, 6 months ago (2015-06-11 18:31:55 UTC) #3
pquitslund
Thanks! On 2015/06/11 18:31:55, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/1179743003/diff/1/pkg/analyzer/lib/src/generated/engine.dart > File pkg/analyzer/lib/src/generated/engine.dart ...
5 years, 6 months ago (2015-06-11 18:34:14 UTC) #4
pquitslund
5 years, 6 months ago (2015-06-11 18:34:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c23a06053922373c7b031c3feae0d521f75aac63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698