Issue 11794048: Fix race condition in Directory.create.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11794048: Fix race condition in Directory.create. (Closed)

Created:
7 years, 11 months ago by Bill Hesse

Modified:
7 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix race condition in Directory.create. BUG=https://code.google.com/p/dart/issues/detail?id=7679 Committed: https://code.google.com/p/dart/source/detail?r=16842

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -13 lines)			Patch
M	runtime/bin/directory_android.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/bin/directory_linux.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	runtime/bin/directory_macos.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View	1 chunk	+5 lines, -4 lines	0 comments	Download
A	tests/standalone/io/directory_create_race_test.dart	View	1 chunk	+43 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Bill Hesse

I chose to remove the early check that a directory exists, before creating it, because ...

7 years, 11 months ago (2013-01-08 16:35:17 UTC) #1

lgtm