Add Stream.fromIterable

Add Stream.fromIterable

Also add Iterable.generate as helper.
Should we have Stream.generate as well?

Committed: https://code.google.com/p/dart/source/detail?r=16848

[Lasse Reichstein Nielsen, 2013-01-08 12:08:34]

PTAL

[floitsch, 2013-01-08 13:02:54]

LGTM.

https://codereview.chromium.org/11794044/diff/5/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/11794044/diff/5/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:23: = _GeneratorIterable;
Add TODO that we need to forward the generic type.

https://codereview.chromium.org/11794044/diff/5/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:584: _Generator<E> _generator;
final

https://codereview.chromium.org/11794044/diff/5/tests/lib/async/stream_from_i...
File tests/lib/async/stream_from_iterable_test.dart (right):

https://codereview.chromium.org/11794044/diff/5/tests/lib/async/stream_from_i...
tests/lib/async/stream_from_iterable_test.dart:17: print("TEST! $counter");
remove.

https://codereview.chromium.org/11794044/diff/5/tests/lib/async/stream_from_i...
tests/lib/async/stream_from_iterable_test.dart:41: List expected =
iter.toList();
Also expect that the list-size is 25.

https://codereview.chromium.org/11794044/diff/5/tests/lib/async/stream_from_i...
tests/lib/async/stream_from_iterable_test.dart:57: // Do a 10 ms pause during
the playback of the iterable.
I think it would be relatively easy to create another slow_consumer_test that
uses Stream.fromIterable. Would be a good test.

[Lasse Reichstein Nielsen, 2013-01-09 11:27:36]

https://codereview.chromium.org/11794044/diff/5/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/11794044/diff/5/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:23: = _GeneratorIterable;
My mistake, I thought it was implicitly forwarded.
If dart2js doesn't implement generics, I'll just use a normal body for now.

https://codereview.chromium.org/11794044/diff/5/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:584: _Generator<E> _generator;
On 2013/01/08 13:02:54, floitsch wrote:
> final

Done.

https://codereview.chromium.org/11794044/diff/5/tests/lib/async/stream_from_i...
File tests/lib/async/stream_from_iterable_test.dart (right):

https://codereview.chromium.org/11794044/diff/5/tests/lib/async/stream_from_i...
tests/lib/async/stream_from_iterable_test.dart:17: print("TEST! $counter");
On 2013/01/08 13:02:54, floitsch wrote:
> remove.

Done.

https://codereview.chromium.org/11794044/diff/5/tests/lib/async/stream_from_i...
tests/lib/async/stream_from_iterable_test.dart:41: List expected =
iter.toList();
On 2013/01/08 13:02:54, floitsch wrote:
> Also expect that the list-size is 25.

Done.

https://codereview.chromium.org/11794044/diff/5/tests/lib/async/stream_from_i...
tests/lib/async/stream_from_iterable_test.dart:57: // Do a 10 ms pause during
the playback of the iterable.
I've made slow_consumer3_test.

[Sean Eagan, 2013-01-09 14:15:20]

https://chromiumcodereview.appspot.com/11794044/diff/10001/sdk/lib/core/itera...
File sdk/lib/core/iterable.dart (right):

https://chromiumcodereview.appspot.com/11794044/diff/10001/sdk/lib/core/itera...
sdk/lib/core/iterable.dart:22: factory Iterable.generate(int count, E
generator(int index)) {
Once we have a some way to get a integer range, I don't think we will need this
constructor:

range(10).mappedBy(f);

and then for Streams:

new Stream.fromIterable(range(10).mappedBy(f)); // or
new Stream.fromIterable(range(10)).mappedBy(f);