Issue 1179193003: Fix a bug with Control+C and browsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179193003: Fix a bug with Control+C and browsers. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 6 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a bug with Control+C and browsers. The cleanup logic in the server was waiting for the browser to actually connect to the browser manager, which caused the browser to exit before the test runner knew that exit was allowed. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/d5c2e66a334d22ff423023de087289913e7eb4ce

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	lib/src/runner/browser/server.dart	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 6 months ago (2015-06-16 23:42:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d5c2e66a334d22ff423023de087289913e7eb4ce (presubmit successful).