Issue 11791051: Support immediate and memory operands for PushArgumentInstr in optimized code.

Issue 11791051: Support immediate and memory operands for PushArgumentInstr in optimized code. (Closed)

Created:
7 years, 11 months ago by Florian Schneider

Modified:
7 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support immediate and memory operands for PushArgumentInstr in optimized code. If a value is a constant or stored on the stack this change avoids loading it into a new register before pushing it. Committed: https://code.google.com/p/dart/source/detail?r=16806

Patch Set 1 #

Total comments: 3

Patch Set 2 : really handle constant operands #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -89 lines)			Patch
M	runtime/vm/assembler_ia32.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_x64.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		6 chunks	+15 lines, -27 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		6 chunks	+15 lines, -27 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	runtime/vm/locations.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/locations.cc	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/11791051/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/11791051/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode50 runtime/vm/intermediate_language_ia32.cc:50: __ pushl(locs()->in(0).reg()); value.reg() https://codereview.chromium.org/11791051/diff/1/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://codereview.chromium.org/11791051/diff/1/runtime/vm/intermediate_language_x64.cc#newcode50 ...

7 years, 11 months ago (2013-01-08 16:19:35 UTC) #2

Florian Schneider

Actually generate constant operands. Please have a quick look. https://codereview.chromium.org/11791051/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/11791051/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode50 runtime/vm/intermediate_language_ia32.cc:50: ...

7 years, 11 months ago (2013-01-08 16:36:56 UTC) #3

lgtm

Expand Messages | Collapse Messages