Issue 11791047: Delay canonicalization of 1.0 * N until after representation selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11791047: Delay canonicalization of 1.0 * N until after representation selection. (Closed)

Created:
7 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Delay canonicalization of 1.0 * N until after representation selection. This allows to avoid Unbox(Box(N)) pair if N is an unboxed double phi: var N = 0.0; while (X) N += 1.0 * N; BUG= Committed: https://code.google.com/p/dart/source/detail?r=16799

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -35 lines)			Patch
	M	runtime/vm/intermediate_language.cc	View		9 chunks	+20 lines, -35 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages