Issue 11791045: Added toMultiSubscriber on Stream.

Issue 11791045: Added toMultiSubscriber on Stream. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added toMultiSubscriber on Stream. (Naming suggestions appreciated.) Committed: https://code.google.com/p/dart/source/detail?r=16861

Patch Set 2 : Now lazily subscribes to source. #

Total comments: 2

Patch Set 3 : Addressed review comments. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -34 lines)			Patch
M	sdk/lib/async/stream.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/async/stream_impl.dart	View	1	5 chunks	+12 lines, -6 lines	0 comments	Download
M	sdk/lib/async/stream_pipe.dart	View	1 2	13 chunks	+30 lines, -28 lines	0 comments	Download
A	tests/lib/async/stream_single_to_multi_subscriber_test.dart	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

https://codereview.chromium.org/11791045/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/11791045/diff/1/sdk/lib/async/stream.dart#newcode28 sdk/lib/async/stream.dart:28: * Returns a multi-subscription stream that produces the same ...

7 years, 11 months ago (2013-01-08 14:06:00 UTC) #2

Lasse Reichstein Nielsen

PTAL https://codereview.chromium.org/11791045/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/11791045/diff/1/sdk/lib/async/stream.dart#newcode28 sdk/lib/async/stream.dart:28: * Returns a multi-subscription stream that produces the ...

7 years, 11 months ago (2013-01-09 15:19:17 UTC) #3

floitsch

LGTM. https://codereview.chromium.org/11791045/diff/6001/sdk/lib/async/stream_pipe.dart File sdk/lib/async/stream_pipe.dart (right): https://codereview.chromium.org/11791045/diff/6001/sdk/lib/async/stream_pipe.dart#newcode10 sdk/lib/async/stream_pipe.dart:10: * The default behavior is to subscribes to ...

7 years, 11 months ago (2013-01-09 16:02:49 UTC) #4

Lasse Reichstein Nielsen

7 years, 11 months ago (2013-01-09 16:16:43 UTC) #5

https://codereview.chromium.org/11791045/diff/6001/sdk/lib/async/stream_pipe....
File sdk/lib/async/stream_pipe.dart (right):

https://codereview.chromium.org/11791045/diff/6001/sdk/lib/async/stream_pipe....
sdk/lib/async/stream_pipe.dart:10: * The default behavior is to subscribes to
the [source] and sends on the
On 2013/01/09 16:02:49, floitsch wrote:
> By default [this] subscribes to [_source] and forwards all events to its own
> subscribers.

Done.

Expand Messages | Collapse Messages