Issue 11788028: Fix future_test.dart and remove future2_test.dart.

Issue 11788028: Fix future_test.dart and remove future2_test.dart. (Closed)

Created:
7 years, 11 months ago by Anders Johnsen

Modified:
7 years, 11 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix future_test.dart and remove future2_test.dart. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16784

Patch Set 2 : Fix status file. #

Patch Set 3 : Fix tests. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -603 lines)			Patch
D	tests/lib/async/future2_test.dart	View		1 chunk	+0 lines, -595 lines	0 comments	Download
M	tests/lib/async/future_test.dart	View	1 2	2 chunks	+179 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1	3 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11788028/diff/1/tests/lib/async/future_test.dart File tests/lib/async/future_test.dart (right): https://codereview.chromium.org/11788028/diff/1/tests/lib/async/future_test.dart#newcode12 tests/lib/async/future_test.dart:12: future.then((x) => Expect.equals("42", x)); Need a port to ...

7 years, 11 months ago (2013-01-08 09:06:52 UTC) #2

Anders Johnsen

7 years, 11 months ago (2013-01-08 09:27:01 UTC) #3

Ty, landing.

https://codereview.chromium.org/11788028/diff/1/tests/lib/async/future_test.dart
File tests/lib/async/future_test.dart (right):

https://codereview.chromium.org/11788028/diff/1/tests/lib/async/future_test.d...
tests/lib/async/future_test.dart:12: future.then((x) => Expect.equals("42", x));
On 2013/01/08 09:06:52, Lasse Reichstein Nielsen wrote:
> Need a port to guarantee that the then is run,

Done.

https://codereview.chromium.org/11788028/diff/1/tests/lib/async/future_test.d...
tests/lib/async/future_test.dart:19: future.catchError((e) =>
Except.fails("Value not expected"));
On 2013/01/08 09:06:52, Lasse Reichstein Nielsen wrote:
> This might actually succeede even if you complete the completer. Also needs a
> port. SO does the next one, or any where you add a listener after completing.

Discussed offline.

https://codereview.chromium.org/11788028/diff/1/tests/lib/async/future_test.d...
tests/lib/async/future_test.dart:42: Expect.equals(3, before);
On 2013/01/08 09:06:52, Lasse Reichstein Nielsen wrote:
> 'before' isn't a good name here :)
> 
> This one doesn't need a port! :)

Done.

https://codereview.chromium.org/11788028/diff/1/tests/lib/async/future_test.d...
tests/lib/async/future_test.dart:90: .catchError((e) => Expect.equals(e.error,
ex));
On 2013/01/08 09:06:52, Lasse Reichstein Nielsen wrote:
> This one works, but it probably should be using the async test framework.
> Working is indistinguishable from not working.

Done.

Expand Messages | Collapse Messages