Issue 11788016: Update dart2js unit tests to new library API.

Issue 11788016: Update dart2js unit tests to new library API. (Closed)

Created:
7 years, 11 months ago by ahe

Modified:
7 years, 11 months ago

Reviewers:
Johnni Winther, karlklose, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update dart2js unit tests to new library API. Committed: https://code.google.com/p/dart/source/detail?r=16702

Patch Set 1 #

Total comments: 1

Patch Set 2 : No need to implement Iterable #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -143 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/tree/nodes.dart	View	1	4 chunks	+5 lines, -94 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/tree/unparser.dart	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/util/link.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js/compiler_helper.dart	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js/dart2js.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js/dart_backend_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js/deprecated_features_test.dart	View		2 chunks	+8 lines, -5 lines	0 comments	Download
A	dart/tests/compiler/dart2js/for_in_test.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js/loop_test.dart	View		3 chunks	+2 lines, -29 lines	0 comments	Download
M	dart/tests/compiler/dart2js/mirrors_test.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/resolver_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js/value_range_test.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	dart/tests/utils/dummy_compiler_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

By the way: Awesome to see the failing part of the loop test being split ...

7 years, 11 months ago (2013-01-07 14:25:02 UTC) #3

Johnni Winther

7 years, 11 months ago (2013-01-07 14:39:26 UTC) #5

lgtm

https://codereview.chromium.org/11788016/diff/1/dart/tests/compiler/dart2js/d...
File dart/tests/compiler/dart2js/deprecated_features_test.dart (right):

https://codereview.chromium.org/11788016/diff/1/dart/tests/compiler/dart2js/d...
dart/tests/compiler/dart2js/deprecated_features_test.dart:40: provider,
handler));
Well, that is ironic; to use a deprecated feature in a test of deprecated
features ;)

Expand Messages | Collapse Messages