Issue 1178643007: Resolve the executable path on Mac OS when sym-linked

Issue 1178643007: Resolve the executable path on Mac OS when sym-linked (Closed)

Created:
5 years, 6 months ago by Søren Gjesse

Modified:
5 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Resolve the executable path on Mac OS when sym-linked Don't try to test sym-linked files on Windows as Junctions only support directories. This helps to locate the Dart SDK (if any) from the path of the dart executable. On Linux the use of /proc/self/exe already takes care of this. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/82535a6e911c0e2059f1af9797da0c9bcdbdb324

Patch Set 1 #

Patch Set 2 : Accidental edit #

Patch Set 3 : Added a few comments #

Total comments: 4

Patch Set 4 : Addressed review comments #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -17 lines)			Patch
M	runtime/bin/platform_win.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	tests/standalone/io/platform_executable_test.dart	View	1 2 3	7 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 2 3	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM https://codereview.chromium.org/1178643007/diff/40001/tests/standalone/io/platform_executable_test.dart File tests/standalone/io/platform_executable_test.dart (right): https://codereview.chromium.org/1178643007/diff/40001/tests/standalone/io/platform_executable_test.dart#newcode110 tests/standalone/io/platform_executable_test.dart:110: //print('*** Running with PATH env set to environment ...

5 years, 6 months ago (2015-06-11 18:34:27 UTC) #2

Søren Gjesse

Thanks for the review. https://codereview.chromium.org/1178643007/diff/40001/tests/standalone/io/platform_executable_test.dart File tests/standalone/io/platform_executable_test.dart (right): https://codereview.chromium.org/1178643007/diff/40001/tests/standalone/io/platform_executable_test.dart#newcode110 tests/standalone/io/platform_executable_test.dart:110: //print('*** Running with PATH env ...

5 years, 6 months ago (2015-06-12 07:24:24 UTC) #3

Søren Gjesse

5 years, 6 months ago (2015-06-12 07:26:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
82535a6e911c0e2059f1af9797da0c9bcdbdb324 (presubmit successful).

Expand Messages | Collapse Messages