Issue 11785028: Commit Martin's patch for pub + lib_v2.

Issue 11785028: Commit Martin's patch for pub + lib_v2. (Closed)

Created:
7 years, 11 months ago by Bob Nystrom

Modified:
7 years, 11 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, kustermann

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Commit Martin's patch for pub + lib_v2. Pub is still all kinds of broken with this, but it's slightly less broken. Some tests pass, and at least the code *parses* after this. Committed: https://code.google.com/p/dart/source/detail?r=16763

Patch Set 1 #

Total comments: 5

Patch Set 2 : Revise. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -136 lines)			Patch
M	pkg/http/lib/src/multipart_file.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/archive/entry.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/archive/input_stream.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	utils/archive/reader.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/pub/command_help.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/pub/command_lish.dart	View		8 chunks	+10 lines, -9 lines	0 comments	Download
M	utils/pub/command_uploader.dart	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	utils/pub/command_version.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/pub/hosted_source.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/pub/http.dart	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	utils/pub/io.dart	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	utils/pub/log.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/pub/oauth2.dart	View	1	9 chunks	+15 lines, -14 lines	0 comments	Download
M	utils/pub/validator.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/validator/dependency.dart	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	utils/pub/validator/directory.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	utils/pub/validator/lib.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	utils/pub/validator/license.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	utils/pub/validator/name.dart	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	utils/pub/validator/pubspec_field.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	utils/tests/archive/reader_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/tests/pub/curl_client_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/tests/pub/io_test.dart	View		6 chunks	+26 lines, -26 lines	0 comments	Download
M	utils/tests/pub/oauth2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/pub_uploader_test.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	1	17 chunks	+54 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Pub is still broken, but I figure this patch as-is is a step in a ...

7 years, 11 months ago (2013-01-07 22:28:29 UTC) #1

nweiz

A few nits, but otherwise LGTM. https://codereview.chromium.org/11785028/diff/1/utils/pub/oauth2.dart File utils/pub/oauth2.dart (right): https://codereview.chromium.org/11785028/diff/1/utils/pub/oauth2.dart#newcode82 utils/pub/oauth2.dart:82: // whenComplete will ...

7 years, 11 months ago (2013-01-07 22:59:55 UTC) #2

Bob Nystrom

7 years, 11 months ago (2013-01-07 23:11:36 UTC) #3

Thanks!

https://codereview.chromium.org/11785028/diff/1/utils/pub/oauth2.dart
File utils/pub/oauth2.dart (right):

https://codereview.chromium.org/11785028/diff/1/utils/pub/oauth2.dart#newcode82
utils/pub/oauth2.dart:82: // whenComplete will drop exceptions on the floor. We
want to ensure that
On 2013/01/07 22:59:55, nweiz wrote:
> Line length.

Done.

https://codereview.chromium.org/11785028/diff/1/utils/tests/pub/test_pub.dart
File utils/tests/pub/test_pub.dart (right):

https://codereview.chromium.org/11785028/diff/1/utils/tests/pub/test_pub.dart...
utils/tests/pub/test_pub.dart:480: subFuture.then((_) =>
registerException(error, future.stackTrace));
On 2013/01/07 22:59:55, nweiz wrote:
> future.stackTrace doesn't exist.

Done. Switched to pull from AsyncError.

Expand Messages | Collapse Messages