Issue 11784022: Update status files for dartc (utils, co19).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11784022: Update status files for dartc (utils, co19). (Closed)

Created:
7 years, 11 months ago by Mads Ager (google)

Modified:
7 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update status files for dartc (utils, co19). Marking the utils ones as pass,fail because they pass on the analyzer. R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16709

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	tests/co19/co19-compiler.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	tests/utils/utils.status	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11784022/diff/1/tests/co19/co19-compiler.status File tests/co19/co19-compiler.status (right): https://codereview.chromium.org/11784022/diff/1/tests/co19/co19-compiler.status#newcode8 tests/co19/co19-compiler.status:8: Language/12_Statements/06_For/2_For_in_A01_t05: Fail Put the co19 issue number to ...

7 years, 11 months ago (2013-01-07 15:16:32 UTC) #2

Mads Ager (google)

7 years, 11 months ago (2013-01-07 15:18:48 UTC) #3

https://codereview.chromium.org/11784022/diff/1/tests/co19/co19-compiler.status
File tests/co19/co19-compiler.status (right):

https://codereview.chromium.org/11784022/diff/1/tests/co19/co19-compiler.stat...
tests/co19/co19-compiler.status:8:
Language/12_Statements/06_For/2_For_in_A01_t05: Fail
On 2013/01/07 15:16:32, floitsch wrote:
> Put the co19 issue number to the right of failing tests. This way it's easier
> for Peter to merge in new co19 revisions.

OK, done.

Expand Messages | Collapse Messages