Issue 11784020: Fixed status files for dart2js corelib/lib/language tests.

Issue 11784020: Fixed status files for dart2js corelib/lib/language tests. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed status files for dart2js corelib/lib/language tests. Moved two tests to lib/async where they belong. R=floitsch@google.com CC=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=16699

Patch Set 1 #

Total comments: 5

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -668 lines)			Patch
M	sdk/lib/async/stream_impl.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/core/iterable.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+23 lines, -0 lines	2 comments	Download
D	tests/corelib/future_test.dart	View	1 chunk	+0 lines, -593 lines	0 comments	Download
D	tests/corelib/futures_test.dart	View	1 chunk	+0 lines, -74 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	tests/language/language_dart2js.status	View	1 chunk	+4 lines, -0 lines	1 comment	Download
A +	tests/lib/async/future2_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tests/lib/async/futures_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+16 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

floitsch

7 years, 11 months ago (2013-01-07 13:52:22 UTC) #2

LGTM.

https://codereview.chromium.org/11784020/diff/1/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/11784020/diff/1/tests/corelib/corelib.status#...
tests/corelib/corelib.status:87: string_replace_all_test: Crash
Please file a bug.

https://codereview.chromium.org/11784020/diff/1/tests/corelib/corelib.status#...
tests/corelib/corelib.status:91: apply2_test: Fail
ditto.

https://codereview.chromium.org/11784020/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/11784020/diff/1/tests/language/language.statu...
tests/language/language.status:540: # Some bug related to assigning function to
typedef-typed field.
add bug number.

https://codereview.chromium.org/11784020/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11784020/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:379: # Timer interface not supported.
I think Karl took care of these.

https://codereview.chromium.org/11784020/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/11784020/diff/1/tests/lib/lib.status#newcode24
tests/lib/lib.status:24: async/future2_test: Fail
Karl should have taken care of these.

Expand Messages | Collapse Messages