Issue 11783069: Adding support checks for WebSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11783069: Adding support checks for WebSocket. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding support checks for WebSocket. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16883

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -35 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View		3 chunks	+1 line, -3 lines	0 comments	Download
M	tests/html/websocket_test.dart	View	1	1 chunk	+18 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View		4 chunks	+8 lines, -25 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm! https://codereview.chromium.org/11783069/diff/1/tests/html/websocket_test.dart File tests/html/websocket_test.dart (right): https://codereview.chromium.org/11783069/diff/1/tests/html/websocket_test.dart#newcode28 tests/html/websocket_test.dart:28: probably can get rid of these two extra ...

7 years, 11 months ago (2013-01-09 20:36:20 UTC) #2

blois

7 years, 11 months ago (2013-01-09 21:07:26 UTC) #3

https://codereview.chromium.org/11783069/diff/1/tests/html/websocket_test.dart
File tests/html/websocket_test.dart (right):

https://codereview.chromium.org/11783069/diff/1/tests/html/websocket_test.dar...
tests/html/websocket_test.dart:28: 
On 2013/01/09 20:36:20, Emily Fortuna wrote:
> probably can get rid of these two extra whitespace lines

Done.

Expand Messages | Collapse Messages

Issue 11783069: Adding support checks for WebSocket. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages