Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 11783017: Fixing SelectElement.options to return a read-only list. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing SelectElement.options to return a read-only list. This got lost in the new collections change. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16753

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M tests/html/html.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 11 months ago (2013-01-07 20:41:55 UTC) #1
Emily Fortuna
7 years, 11 months ago (2013-01-07 20:49:46 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698