Restore the bytes promoted counter.

Restore the bytes promoted counter.

Committed: https://code.google.com/p/dart/source/detail?r=16764

[siva, 2013-01-07 22:33:45]

LGTM once you have a comment detailing the use. This would be useful in order to
ensure that it is not deleted in the interim.

https://chromiumcodereview.appspot.com/11783015/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://chromiumcodereview.appspot.com/11783015/diff/1/runtime/vm/scavenger.c...
runtime/vm/scavenger.cc:250: intptr_t bytes_promoted_;
Currently this variable is not being used anywhere in the code. Could you add a
comment here indicating how the field will be used.

[siva, 2013-01-07 22:35:33]

https://codereview.chromium.org/11783015/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/11783015/diff/1/runtime/vm/scavenger.cc#newco...
runtime/vm/scavenger.cc:112: intptr_t bytes_promoted() { return bytes_promoted_;
}
intptr_t bytes_promoted() const { ... }

[cshapiro, 2013-01-07 23:16:22]

https://codereview.chromium.org/11783015/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/11783015/diff/1/runtime/vm/scavenger.cc#newco...
runtime/vm/scavenger.cc:112: intptr_t bytes_promoted() { return bytes_promoted_;
}
I thought about doing this during my original change that added this value.

However, none of the other fields in the class make this distinction, so it
looks out of place.

I will add it to this change but it does not appear consistent with the rest of
this class.

https://codereview.chromium.org/11783015/diff/1/runtime/vm/scavenger.cc#newco...
runtime/vm/scavenger.cc:250: intptr_t bytes_promoted_;
I will add a TODO comment about this value's relationship to survival
statistics.