Issue 1178203002: Don't visit named argument labels when computing constant dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178203002: Don't visit named argument labels when computing constant dependencies. (Closed)

Created:
5 years, 6 months ago by Paul Berry

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't visit named argument labels when computing constant dependencies. This fixes some crashes with the new task model. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/b715b97147ee4fe3de54eb5699e439b3efd821d7

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	pkg/analyzer/lib/src/generated/constant.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/generated/non_error_resolver_test.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

5 years, 6 months ago (2015-06-11 17:36:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b715b97147ee4fe3de54eb5699e439b3efd821d7 (presubmit successful).