Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 11779024: Fix FrozenElementListIterator. (Closed)

Created:
7 years, 11 months ago by floitsch
Modified:
7 years, 11 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix FrozenElementListIterator. Committed: https://code.google.com/p/dart/source/detail?r=16726

Patch Set 1 #

Patch Set 2 : Run go.sh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1326 lines, -1323 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 3 chunks +2 lines, -674 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +2 lines, -648 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 1 chunk +673 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 1 chunk +647 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
TBR.
7 years, 11 months ago (2013-01-07 16:37:21 UTC) #1
Anders Johnsen
LGTM, however, odd that this CL moved HTML code around?
7 years, 11 months ago (2013-01-08 08:41:24 UTC) #2
floitsch
7 years, 11 months ago (2013-01-08 10:46:15 UTC) #3
Message was sent while issue was closed.
On 2013/01/08 08:41:24, Anders Johnsen wrote:
> LGTM, however, odd that this CL moved HTML code around?

The html change turned out to be bad. Peter reverted it for me.

Powered by Google App Engine
This is Rietveld 408576698