Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1177833002: Ensure that prefix?.loadLibrary() generates the proper compile-time error. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure that prefix?.loadLibrary() generates the proper compile-time error. loadLibrary() is special-cased in analyzer, so we need special-case code to make sure that it can't be invoked using "?.". Fixes #23463. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c03b8fe45199cecfc8bdd112429b97fe8f73a220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 6 months ago (2015-06-10 21:34:30 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-10 21:35:50 UTC) #3
Paul Berry
5 years, 6 months ago (2015-06-10 21:43:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c03b8fe45199cecfc8bdd112429b97fe8f73a220 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698