Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 11778013: Cleanup handles more efficiently, ensures we don't have to iterate over them (Closed)

Created:
7 years, 11 months ago by siva
Modified:
7 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup handles more efficiently, ensures we don't have to iterate over them while visiting objects during GC. - Add handle scopes during class finialization - Add handle scopes to different stages of the compiler - Ensure that we iterate only to the top of scoped handles while visiting objects Committed: https://code.google.com/p/dart/source/detail?r=16683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M runtime/vm/benchmark_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/handles_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
7 years, 11 months ago (2013-01-05 06:10:39 UTC) #1
Ivan Posva
7 years, 11 months ago (2013-01-06 19:46:06 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698