Issue 11777016: Fix some failures in html/element_test by changing where(...)[0] to where(...).first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11777016: Fix some failures in html/element_test by changing where(...)[0] to where(...).first. (Closed)

Created:
7 years, 11 months ago by Bill Hesse

Modified:
7 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix some failures in html/element_test by changing where(...)[0] to where(...).first. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16707

Patch Set 1 #

Patch Set 2 : Add relaxation of List.from parameter type. #

Patch Set 3 : Fix type check on .where(...) from List to Iterable. #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	sdk/lib/core/list.dart	View	1	1 chunk	+1 line, -1 line	1 comment	Download
	M	tests/html/element_test.dart	View	1 2	3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

7 years, 11 months ago (2013-01-07 14:59:02 UTC) #3

LGTM.

https://codereview.chromium.org/11777016/diff/6001/sdk/lib/core/list.dart
File sdk/lib/core/list.dart (right):

https://codereview.chromium.org/11777016/diff/6001/sdk/lib/core/list.dart#new...
sdk/lib/core/list.dart:41: for (var e in other) {
for (E e in other) {

Expand Messages | Collapse Messages