Make the "pub" and "pkg" test suites run Dart from the built SDK.

Make the "pub" and "pkg" test suites run Dart from the built SDK.

I'm not using a test.dart command-line argument for this because
I want to enforce that they *always* run out of the built SDK
directory. This will be needed in a later patch so that the pub
test code can find the SDK directory easily relative to the
currently running Dart executable.

Committed: https://code.google.com/p/dart/source/detail?r=16652

[Bob Nystrom, 2013-01-04 20:56:00]

This is a step along the path to get everything in "pkg" using "package:"
imports.

Pub uses pkg/oauth2, which in turn imports pkg/http. Soon, oauth2 will import
http using "package:". But pub also directly imports http, which means it will
need to use "package:" too.

I've got other patches in progress to make that work. One consequence is that
it's simpler for the pub test code to find the "packages" directory for pub if
the Dart binary running the test code itself is the one in
<buildDir>/dart-sdk/bin and not just <buildDir>.

[Emily Fortuna, 2013-01-04 21:39:10]

lgtm, with one comment added, please.

https://codereview.chromium.org/11777003/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11777003/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:110: bool get useSdk {
can we add a little TODO here that says that we plan to switch all tests to run
with the SDK eventually, so this code should go away?

[Bob Nystrom, 2013-01-04 22:29:45]

Thanks!

https://codereview.chromium.org/11777003/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11777003/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:110: bool get useSdk {
On 2013/01/04 21:39:10, Emily Fortuna wrote:
> can we add a little TODO here that says that we plan to switch all tests to
run
> with the SDK eventually, so this code should go away? 

Done.