Issue 11776007: Handle optimized code blocks in debugger stack trace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11776007: Handle optimized code blocks in debugger stack trace (Closed)

Created:
7 years, 11 months ago by hausner

Modified:
7 years, 11 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Handle optimized code blocks in debugger stack trace Removed an old restriction that debugger activation frames are expected to be non-optimized code. Fixes bug 5944. Committed: https://code.google.com/p/dart/source/detail?r=16665

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -14 lines)			Patch
	M	runtime/vm/debugger.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	runtime/vm/debugger.cc	View	1 2	5 chunks	+27 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11776007/diff/3001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/11776007/diff/3001/runtime/vm/debugger.cc#newcode166 runtime/vm/debugger.cc:166: function_ = DartCode().function(); Why cache the function at ...

7 years, 11 months ago (2013-01-04 22:50:15 UTC) #2

hausner

7 years, 11 months ago (2013-01-05 00:46:06 UTC) #3

Thanks. Made one addition: do not return any variables to the debugger for
frames that contain optimized code.

https://codereview.chromium.org/11776007/diff/3001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/11776007/diff/3001/runtime/vm/debugger.cc#new...
runtime/vm/debugger.cc:166: function_ = DartCode().function();
On 2013/01/04 22:50:15, srdjan wrote:
> Why cache the function at all?

It is used in a few locations. May save a few handle allocations.
ActivationFrames are short-lived objects, they go away quickly, so caching this
is cheap.

Expand Messages | Collapse Messages