Issue 11773040: Canonicalize away simple arithmetic equivalences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11773040: Canonicalize away simple arithmetic equivalences. (Closed)

Created:
7 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Canonicalize away simple arithmetic equivalences. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16795

Patch Set 2 : Add support for Mint. Fix bug in 0.0 * X identity. #

Patch Set 3 : Ensure that 1.0 * N is correctly coerced to double. #

Patch Set 4 : Add test, address comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+221 lines, -3 lines)			Patch
M	runtime/vm/intermediate_language.h	View	1 2	5 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3	1 chunk	+175 lines, -0 lines	0 comments	Download
A	tests/language/arithmetic_canonicalization_test.dart	View	1 2 3	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. Please also add the according tests. https://codereview.chromium.org/11773040/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/11773040/diff/1/runtime/vm/intermediate_language.cc#newcode1408 runtime/vm/intermediate_language.cc:1408: intptr_t value; ...

7 years, 11 months ago (2013-01-08 12:15:45 UTC) #2

Vyacheslav Egorov (Google)

7 years, 11 months ago (2013-01-08 13:26:54 UTC) #3

Thanks for the review. Comments addressed. Test added. Landing