Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 11773032: Fix htmlconfig (Closed)

Created:
7 years, 11 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna, gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M pkg/unittest/lib/html_config.dart View 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
7 years, 11 months ago (2013-01-07 22:37:04 UTC) #1
gram
lgtm
7 years, 11 months ago (2013-01-07 22:37:43 UTC) #2
Emily Fortuna
https://codereview.chromium.org/11773032/diff/1/pkg/unittest/lib/html_config.dart File pkg/unittest/lib/html_config.dart (left): https://codereview.chromium.org/11773032/diff/1/pkg/unittest/lib/html_config.dart#oldcode131 pkg/unittest/lib/html_config.dart:131: void onStart() { I assume this means we probably ...
7 years, 11 months ago (2013-01-07 23:32:25 UTC) #3
Siggi Cherem (dart-lang)
On 2013/01/07 23:32:25, Emily Fortuna wrote: > https://codereview.chromium.org/11773032/diff/1/pkg/unittest/lib/html_config.dart > File pkg/unittest/lib/html_config.dart (left): > > https://codereview.chromium.org/11773032/diff/1/pkg/unittest/lib/html_config.dart#oldcode131 ...
7 years, 11 months ago (2013-01-08 00:39:36 UTC) #4
Emily Fortuna
7 years, 11 months ago (2013-01-08 00:41:04 UTC) #5
Message was sent while issue was closed.
On 2013/01/08 00:39:36, Siggi Cherem (dart-lang) wrote:
> On 2013/01/07 23:32:25, Emily Fortuna wrote:
> >
>
https://codereview.chromium.org/11773032/diff/1/pkg/unittest/lib/html_config....
> > File pkg/unittest/lib/html_config.dart (left):
> > 
> >
>
https://codereview.chromium.org/11773032/diff/1/pkg/unittest/lib/html_config....
> > pkg/unittest/lib/html_config.dart:131: void onStart() {
> > I assume this means we probably need to do the same thing for
> > "html_individual_config"? Do you want me to do that?
> 
> seems that html_individual_config is not overriding the onInit method, so it
> might be ok without any changes there.

Ah, right. I hadn't looked at the code when I made that comment, I was going
from memory.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698