Issue 11773008: - Preallocate non-named ArgumentsDescriptors with a small amount of parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11773008: - Preallocate non-named ArgumentsDescriptors with a small amount of parameters. (Closed)

Created:
7 years, 11 months ago by Ivan Posva

Modified:
7 years, 11 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Preallocate non-named ArgumentsDescriptors with a small amount of parameters. Committed: https://code.google.com/p/dart/source/detail?r=16734

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -4 lines)			Patch
M	runtime/vm/dart.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_entry.h	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View	1	4 chunks	+27 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/11773008/diff/1/runtime/vm/dart_entry.cc File runtime/vm/dart_entry.cc (right): https://codereview.chromium.org/11773008/diff/1/runtime/vm/dart_entry.cc#newcode305 runtime/vm/dart_entry.cc:305: if (canonicalize) { I suppose you do not ...

7 years, 11 months ago (2013-01-05 01:05:29 UTC) #2

Ivan Posva

7 years, 11 months ago (2013-01-07 18:27:12 UTC) #3

https://codereview.chromium.org/11773008/diff/1/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/11773008/diff/1/runtime/vm/dart_entry.cc#newc...
runtime/vm/dart_entry.cc:305: if (canonicalize) {
On 2013/01/05 01:05:29, regis wrote:
> I suppose you do not canonicalize the cached descriptors so that a reference
to
> them is not stored twice. But why don't you make them immutable?

Making them immutable now. For this we need to make the ImmutableArray class
known to the VM isolate.

https://codereview.chromium.org/11773008/diff/1/runtime/vm/dart_entry.h
File runtime/vm/dart_entry.h (right):

https://codereview.chromium.org/11773008/diff/1/runtime/vm/dart_entry.h#newco...
runtime/vm/dart_entry.h:79: kCachedDescriptors = 32
On 2013/01/05 01:05:29, regis wrote:
> kCachedDescriptorCount?

Done.

Expand Messages | Collapse Messages

Issue 11773008: - Preallocate non-named ArgumentsDescriptors with a small amount of parameters. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages