Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 117723003: Fix most UDP issues on Mac OS (Closed)

Created:
7 years ago by Søren Gjesse
Modified:
7 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix most UDP issues on Mac OS We still do not test getting SO_BROADCAST, as it (at least on my laptop) returns false even if it has just been turned on. Setting SO_REUSEADDR for datagram sockets also behaves differently compared to Linux and Windows. IPv6 multicast as I could not test it on my laptop. R=ajohnsen@google.com BUG=http://dartbug.com/1975 Committed: https://code.google.com/p/dart/source/detail?r=31223

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -34 lines) Patch
M runtime/bin/socket_macos.cc View 3 chunks +3 lines, -25 lines 2 comments Download
M runtime/bin/socket_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/raw_datagram_socket_test.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years ago (2013-12-18 10:50:27 UTC) #1
Anders Johnsen
LGTM, with BUG= updated. https://codereview.chromium.org/117723003/diff/1/runtime/bin/socket_macos.cc File runtime/bin/socket_macos.cc (right): https://codereview.chromium.org/117723003/diff/1/runtime/bin/socket_macos.cc#newcode634 runtime/bin/socket_macos.cc:634: return JoinOrLeaveMulticast(fd, addr, interface, interfaceIndex, ...
7 years ago (2013-12-18 11:29:48 UTC) #2
Søren Gjesse
https://codereview.chromium.org/117723003/diff/1/runtime/bin/socket_macos.cc File runtime/bin/socket_macos.cc (right): https://codereview.chromium.org/117723003/diff/1/runtime/bin/socket_macos.cc#newcode634 runtime/bin/socket_macos.cc:634: return JoinOrLeaveMulticast(fd, addr, interface, interfaceIndex, true); On 2013/12/18 11:29:49, ...
7 years ago (2013-12-18 11:56:28 UTC) #3
Søren Gjesse
7 years ago (2013-12-18 12:23:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698