Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 117723002: Allow the native resolver to setup whether it needs the Dart API scope to (Closed)

Created:
7 years ago by siva
Modified:
7 years ago
Reviewers:
zra, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Allow the native resolver to setup whether it needs the Dart API scope to be setup automatically or not when a native function is invoked. This would allow the embedder to treat some native functions as leaf functions whose invocation can be very light. R=hausner@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=31286

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -55 lines) Patch
M runtime/bin/builtin.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/builtin_gen_snapshot.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/bin/builtin_natives.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/bin/io_natives.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/io_natives.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/bin/test_extension.c View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M runtime/bin/vmservice_impl.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/include/dart_api.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/benchmark_test.cc View 1 2 3 chunks +13 lines, -3 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/code_descriptors_test.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/custom_isolate_test.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 13 chunks +54 lines, -16 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/exceptions_test.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/native_arguments.h View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/native_entry.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/native_entry.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/stack_frame_test.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 2 2 chunks +14 lines, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 2 2 chunks +15 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M samples/sample_extension/sample_extension.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years ago (2013-12-18 22:15:36 UTC) #1
hausner
lgtm
7 years ago (2013-12-19 00:46:20 UTC) #2
zra
lgtm
7 years ago (2013-12-19 15:58:42 UTC) #3
siva
7 years ago (2013-12-19 17:48:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r31286 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698