Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1177043010: Add tests for e?.v++, e?.v--, ++e?.v, and --e?.v. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org, gbracha, hausner
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for e?.v++, e?.v--, ++e?.v, and --e?.v. The tests for e?.v++ and e?.v-- validate the spec text added in 58708e3 (as clarified by 1ab7736). The tests for ++e?.v and --e?.v weren't mandated by any spec change, but since these expressions weren't previously tested, it seemed reasonable to add tests for them. All tests pass under the current implementation of "?." in analyzer and dart2js. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/76bbccf28f799efcbc2b6bd336b12a15d73844dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
A tests/language/conditional_property_increment_decrement_test.dart View 1 chunk +74 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Paul Berry
5 years, 6 months ago (2015-06-17 17:18:33 UTC) #2
Brian Wilkerson
LGTM. FYI, it looks like null-aware operators are going into the VM right now (https://codereview.chromium.org/1180903002/).
5 years, 6 months ago (2015-06-17 17:30:31 UTC) #3
Paul Berry
On 2015/06/17 17:30:31, Brian Wilkerson wrote: > LGTM. > > FYI, it looks like null-aware ...
5 years, 6 months ago (2015-06-17 18:08:43 UTC) #4
hausner
If you check in first, I'll make sure your new tests are passing in the ...
5 years, 6 months ago (2015-06-17 18:14:14 UTC) #6
Paul Berry
On 2015/06/17 18:14:14, hausner wrote: > If you check in first, I'll make sure your ...
5 years, 6 months ago (2015-06-17 18:14:53 UTC) #7
Paul Berry
5 years, 6 months ago (2015-06-17 18:17:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
76bbccf28f799efcbc2b6bd336b12a15d73844dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698