Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 11770004: Rename Date to DateTime. (Closed)

Created:
7 years, 11 months ago by floitsch
Modified:
7 years, 11 months ago
CC:
reviews_dartlang.org, Mads Ager (google), Anders Johnsen
Visibility:
Public.

Description

Rename Date to DateTime. BUG=http://dartbug.com/1424 Committed: https://code.google.com/p/dart/source/detail?r=17549

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments and keep Backwards-compatibility class Date. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+745 lines, -1115 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/Clock.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/CoreRuntimeTypesTest.dart View 1 chunk +2 lines, -2 lines 0 comments Download
editor/util/debuggertest/pets.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
pkg/intl/example/basic/basic_example.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/date_format.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/intl/lib/intl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/src/date_format_field.dart View 13 chunks +22 lines, -22 lines 0 comments Download
M pkg/intl/lib/src/date_format_helpers.dart View 2 chunks +3 lines, -3 lines 0 comments Download
pkg/intl/test/date_time_format_test_core.dart View 1 11 chunks +14 lines, -14 lines 0 comments Download
M pkg/logging/lib/logging.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/oauth2/lib/src/authorization_code_grant.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/oauth2/lib/src/credentials.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/oauth2/lib/src/handle_access_token_response.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/oauth2/test/client_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/oauth2/test/credentials_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/oauth2/test/handle_access_token_response_test.dart View 1 chunk +1 line, -1 line 0 comments Download
pkg/serialization/test/serialization_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
pkg/unittest/lib/compact_vm_config.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
pkg/unittest/lib/html_layout_config.dart View 1 7 chunks +8 lines, -8 lines 0 comments Download
pkg/unittest/lib/interactive_html_config.dart View 1 7 chunks +8 lines, -8 lines 0 comments Download
M pkg/unittest/lib/mock.dart View 11 chunks +12 lines, -12 lines 0 comments Download
M pkg/unittest/lib/src/test_case.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/unittest/test/mock_test.dart View 3 chunks +11 lines, -11 lines 0 comments Download
runtime/bin/secure_socket.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/date_patch.dart View 1 4 chunks +17 lines, -17 lines 0 comments Download
M runtime/lib/math_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M samples/chat/chat_server_lib.dart View 9 chunks +15 lines, -15 lines 0 comments Download
M samples/chat/dart_client/chat.dart View 1 chunk +1 line, -1 line 0 comments Download
samples/clock/web/balls.dart View 1 1 chunk +1 line, -1 line 0 comments Download
samples/clock/web/clock.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
samples/solar/web/solar.dart View 1 1 chunk +1 line, -1 line 0 comments Download
samples/solar3d/web/solar.dart View 1 1 chunk +1 line, -1 line 0 comments Download
samples/swarm/DataSource.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M samples/swarm/swarm_ui_lib/base/AnimationScheduler.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/touch/TimeUtil.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/util/DateUtils.dart View 7 chunks +15 lines, -15 lines 0 comments Download
M samples/third_party/dromaeo/common/BenchUtil.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/dromaeo/tests/RunnerSuite.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M samples/time/time_server.dart View 1 chunk +1 line, -1 line 0 comments Download
sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 1 1 chunk +11 lines, -11 lines 0 comments Download
sdk/lib/_internal/compiler/implementation/ssa/tracer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
sdk/lib/core/core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
sdk/lib/core/corelib_sources.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/date.dart View 1 1 chunk +0 lines, -428 lines 0 comments Download
sdk/lib/core/date_time.dart View 1 7 chunks +245 lines, -187 lines 0 comments Download
M sdk/lib/html/html_common/conversions.dart View 2 chunks +3 lines, -3 lines 0 comments Download
sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/file.dart View 1 chunk +3 lines, -3 lines 0 comments Download
sdk/lib/io/file_impl.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/http.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/io/http_headers.dart View 9 chunks +12 lines, -12 lines 0 comments Download
sdk/lib/io/http_impl.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/http_session.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/io/http_utils.dart View 4 chunks +6 lines, -6 lines 0 comments Download
sdk/lib/io/secure_socket.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/io/timer_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
tests/compiler/dart2js_extra/mirror_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/core_runtime_types_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/date_time2_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/corelib/date_time3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/date_time4_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/corelib/date_time5_test.dart View 8 chunks +9 lines, -9 lines 0 comments Download
M tests/corelib/date_time6_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/corelib/date_time7_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/corelib/date_time8_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/date_time_test.dart View 64 chunks +140 lines, -140 lines 0 comments Download
M tests/corelib/is_operator_basic_types_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/multiple_timer_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/isolate/timer_isolate_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/timer_repeat_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/isolate/timer_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/language/issue4157508_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/type_error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/http_advanced_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/io/http_connection_close_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_date_test.dart View 3 chunks +15 lines, -15 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/secure_socket_bad_certificate_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_runner_exit_code_script.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_Window.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLInputElement.darttemplate View 1 5 chunks +5 lines, -5 lines 0 comments Download
M utils/template/uitest.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/testrunner/layout_test_controller.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M utils/testrunner/standard_test_runner.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/oauth2_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/yaml_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/template/real_app.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
Not yet 100% decided, but I have been convinced that Timestamp is not a good ...
7 years, 11 months ago (2013-01-08 18:32:51 UTC) #1
floitsch
Still missing status-file updates for co19.
7 years, 11 months ago (2013-01-08 18:33:07 UTC) #2
Lasse Reichstein Nielsen
LGTM with useless rambling complaints. https://codereview.chromium.org/11770004/diff/1/sdk/lib/core/date.dart File sdk/lib/core/date.dart (right): https://codereview.chromium.org/11770004/diff/1/sdk/lib/core/date.dart#newcode5 sdk/lib/core/date.dart:5: part of dart.core; Rename ...
7 years, 11 months ago (2013-01-09 16:09:29 UTC) #3
floitsch
7 years, 11 months ago (2013-01-22 20:23:39 UTC) #4
PTAL. I kept the Date class for backwards compatibility. At least for some
days/weeks.

https://codereview.chromium.org/11770004/diff/1/sdk/lib/core/date.dart
File sdk/lib/core/date.dart (right):

https://codereview.chromium.org/11770004/diff/1/sdk/lib/core/date.dart#newcode5
sdk/lib/core/date.dart:5: part of dart.core;
On 2013/01/09 16:09:29, Lasse Reichstein Nielsen wrote:
> Rename file to datetime.dart

renamed to date_time.dart

https://codereview.chromium.org/11770004/diff/1/sdk/lib/core/date.dart#newcode99
sdk/lib/core/date.dart:99: // tools don't yet. Eventually we want to have
default values here.
On 2013/01/09 16:09:29, Lasse Reichstein Nielsen wrote:
> Comment out-dated? We have a default value in the signature.

Done.

Powered by Google App Engine
This is Rietveld 408576698