Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1176983002: Capture more errors and improve duplicate error removal (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Capture more errors and improve duplicate error removal R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/caa03b0b9f2faac0d6f341f08f458ba9fbc43b8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -36 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 13 chunks +40 lines, -34 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-10 21:38:12 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-10 22:02:08 UTC) #3
Brian Wilkerson
5 years, 6 months ago (2015-06-10 23:32:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
caa03b0b9f2faac0d6f341f08f458ba9fbc43b8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698