Issue 11759007: Fix Directory.create(recursive: true) for non-existing paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11759007: Fix Directory.create(recursive: true) for non-existing paths. (Closed)

Created:
7 years, 11 months ago by Mads Ager (google)

Modified:
7 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Directory.create(recursive: true) for non-existing paths. R=sgjesse@google.com BUG=dartbug.com/7679 Committed: https://code.google.com/p/dart/source/detail?r=16605

Patch Set 2 : Address comments. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -4 lines)			Patch
	M	sdk/lib/io/directory_impl.dart	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download
	A	tests/standalone/io/regress_7679_test.dart	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/11759007/diff/1/sdk/lib/io/directory_impl.dart File sdk/lib/io/directory_impl.dart (right): https://codereview.chromium.org/11759007/diff/1/sdk/lib/io/directory_impl.dart#newcode92 sdk/lib/io/directory_impl.dart:92: if (index == -1) index = dirsToCreate.length; I ...

7 years, 11 months ago (2013-01-03 15:11:13 UTC) #2

Mads Ager (google)

7 years, 11 months ago (2013-01-03 16:04:16 UTC) #3

https://codereview.chromium.org/11759007/diff/1/sdk/lib/io/directory_impl.dart
File sdk/lib/io/directory_impl.dart (right):

https://codereview.chromium.org/11759007/diff/1/sdk/lib/io/directory_impl.dar...
sdk/lib/io/directory_impl.dart:92: if (index == -1) index = dirsToCreate.length;
On 2013/01/03 15:11:13, Søren Gjesse wrote:
> I can't figure out how the _computeExistingIndex can complete with -1.

D'oh! That was what it used to do, so this was my first 'fix' which I didn't
like. I forgot to remove it again. :-)

Expand Messages | Collapse Messages

Issue 11759007: Fix Directory.create(recursive: true) for non-existing paths. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages