Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 11757002: Fixing ArrayBuffer et al on IE. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing ArrayBuffer et al on IE. - Added ArrayBuffer.supported check to see if typed arrays are supported. - Added annotations to ArrayBufferView to indicate platform support. - Updated tests to check for support. - Added polyfill for ArrayBuffer.slice to allow more tests to pass. - Fixed DataView on IE. - Fixed class annotations not being emitted on Dartium. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16592

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -45 lines) Patch
M sdk/lib/_internal/compiler/implementation/lib/native_helper.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 3 chunks +44 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 13 chunks +44 lines, -0 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/html/html.status View 4 chunks +1 line, -13 lines 0 comments Download
M tests/html/typed_arrays_1_test.dart View 1 chunk +46 lines, -26 lines 0 comments Download
M tests/html/typed_arrays_2_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/html/typed_arrays_3_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/html/typed_arrays_4_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/html/typed_arrays_5_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/html/typed_arrays_arraybuffer_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/html/typed_arrays_dataview_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/html/typed_arrays_range_checks_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
A tools/dom/templates/html/dart2js/impl_ArrayBuffer.darttemplate View 1 chunk +38 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/dart_implementation.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 11 months ago (2013-01-02 21:14:51 UTC) #1
sra1
7 years, 11 months ago (2013-01-02 22:01:01 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698