Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1175393004: Refactor SsaBuilder.handleSendSet; handle simple assignments directly. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor SsaBuilder.handleSendSet; handle simple assignments directly. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/2afbcc41cb61df0acdae7e8992636fbcfe9a0780

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -230 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 4 chunks +457 lines, -230 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-17 07:38:09 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1175393004/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1175393004/diff/1/pkg/compiler/lib/src/ssa/builder.dart#newcode5620 pkg/compiler/lib/src/ssa/builder.dart:5620: // If node is of the from [:super.foo[0] ...
5 years, 6 months ago (2015-06-17 07:51:01 UTC) #3
Johnni Winther
https://codereview.chromium.org/1175393004/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1175393004/diff/1/pkg/compiler/lib/src/ssa/builder.dart#newcode5620 pkg/compiler/lib/src/ssa/builder.dart:5620: // If node is of the from [:super.foo[0] += ...
5 years, 6 months ago (2015-06-17 09:36:29 UTC) #4
Johnni Winther
5 years, 6 months ago (2015-06-17 09:41:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2afbcc41cb61df0acdae7e8992636fbcfe9a0780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698