Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1174943002: Fix checked mode service test. (Closed)

Created:
5 years, 6 months ago by Florian Schneider
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix checked mode service test. The object pool is not an Instance, but a VM object now. TBR=johnmccutchan@google.com, Committed: https://github.com/dart-lang/sdk/commit/09b59b6c169db781127e014ac7dbfda8c9133733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/observatory/lib/src/service/object.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 6 months ago (2015-06-10 11:22:46 UTC) #2
Florian Schneider
Committed patchset #1 (id:1) manually as 09b59b6c169db781127e014ac7dbfda8c9133733 (presubmit successful).
5 years, 6 months ago (2015-06-10 11:24:13 UTC) #3
Cutch
5 years, 6 months ago (2015-06-10 12:50:51 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698