Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1174903002: Revert execvpe on Mac and fix usage of strerror_r. (Closed)

Created:
5 years, 6 months ago by Anders Johnsen
Modified:
5 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert execvpe on Mac and fix usage of strerror_r. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/bd25e641f2819f6d353f712f3831eec767f37be6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M runtime/bin/process_macos.cc View 3 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Anders Johnsen
5 years, 6 months ago (2015-06-10 09:03:19 UTC) #2
Søren Gjesse
lgtm
5 years, 6 months ago (2015-06-10 09:11:56 UTC) #3
Anders Johnsen
5 years, 6 months ago (2015-06-10 09:13:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd25e641f2819f6d353f712f3831eec767f37be6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698